711 search box

[JerryWu1234]

What is it?

• Feature / enhancement
• Bug
• Docs / tests
• Other

Why is it needed?

Checklist:

• My code follows the developer guidelines of this project
• I have performed a self-review of my own code
• I have ran pnpm change and documented my changes
• I have add necessary docs (if needed)
• Added new tests to cover the fix / functionality

[changeset-bot]

⚠️ No Changeset found

Latest commit: a2e42b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

Open in Stackblitz

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui@832

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/styled@832

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@832

pnpm add https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/utils@832

commit: a2e42b6

[maiieul]

Hey @JerryWu1234 is this still in draft?

[JerryWu1234]

[JerryWu1234]

[JerryWu1234]

Hey I went through the PR and here's some things that I noticed:

• I still see the website env file with the API key data, should that be hidden?

• Sometimes I'm unable to open the search. I have to restart the dev server (maybe related to localStorage?)

Is there a reason you remade a modal from scratch instead of using the Qwik UI modal? The Qwik UI modal has focus trap functionality out of the box.

• When I did a search, it immediately gives an error and there is no results.

In dev mode the search bar opens sometimes. In preview mode I don't see the search bar icon, but I do is it when running the cloudflare preview which is interesting

[maiieul]

Thanks @JerryWu1234! Don't hesitate to request our review when you've been through all issues above 🙏

[JerryWu1234]

Hey @JerryWu1234 is this still in draft?

I'm on honeymoon. And will continue to work next week

[maiieul]

Just tested it out. Really cool to see the progress @JerryWu1234! 很棒😊😛

Just one thing I noticed. After selecting a search item on the modal it disappears but then it's not possible to scroll on the page anymore. Have you switched to using the Qwik UI Modal?

[JerryWu1234]

Have you switched to using the Qwik UI Modal?

yes I have

[JerryWu1234]

Just tested it out. Really cool to see the progress @JerryWu1234! 很棒😊😛

After selecting a search item on the modal it disappears but then it's not possible to scroll on the page anymore

I will check it after you fix that error.

[JerryWu1234]

[maiieul]

@JerryWu1234 I fixed the error in #944 . Was simply a matter of adding ?inline to the CSS imports ✌️

[JerryWu1234]

@JerryWu1234 I fixed the error in #944 . Was simply a matter of adding ?inline to the CSS imports ✌️

�thanks

[JerryWu1234]

@JerryWu1234 I fixed the error in #944 . Was simply a matter of adding ?inline to the CSS imports ✌️

Actually, I didn't use any css in my PR. lol.
Still error when I run pnpm run dev

[JerryWu1234]

@maiieul

[maiieul]

That's normal I couldn't merge my fix yet. I don't understand what's blocking you here. Does the error message prevent you from doing something? Imo you can just ignore the message. No need to 'pnpm build' you can just run preview.

[JerryWu1234]

That's normal I couldn't merge my fix yet. I don't understand what's blocking you here. Does the error message prevent you from doing something? Imo you can just ignore the message. No need to 'pnpm build' you can just run preview.

"OK, this bug will block me a little. If there are results that were searched, a new page will open when I click an item on the list. However I can ignore it now