Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensitivity analysis section #270

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Add sensitivity analysis section #270

merged 11 commits into from
Oct 10, 2024

Conversation

LucyMcGowan
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@malcolmbarrett malcolmbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is the best explanation I've seen you give for the scaled aspect of these procedures.

I don't think the tables are working well, though, when rendered. I think they need to be pared down quite a bit for this setting.

I'm also going to run the styler so make sure to pull

/style

I'll do some more copy-editing here when I come back to this chapter but looks good.

chapters/21-sensitivity.qmd Outdated Show resolved Hide resolved
chapters/21-sensitivity.qmd Outdated Show resolved Hide resolved
chapters/21-sensitivity.qmd Outdated Show resolved Hide resolved
chapters/21-sensitivity.qmd Outdated Show resolved Hide resolved
```{r}
#| label: fig-sens-array
#| fig-cap: >
#| Impact of a Normally distributed unmeasured confounder with an assumed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#| Impact of a Normally distributed unmeasured confounder with an assumed
#| Impact of a normally distributed unmeasured confounder with an assumed

```{r}
#| label: fig-sens-array-2
#| fig-cap: >
#| Impact of a Normally distributed unmeasured confounder with an observed coefficient of #| 6.58 (dashed line).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#| Impact of a Normally distributed unmeasured confounder with an observed coefficient of #| 6.58 (dashed line).
#| Impact of a normally distributed unmeasured confounder with an observed coefficient of 6.58 (dashed line).

@LucyMcGowan
Copy link
Collaborator Author

Awesome thank you! When you say pull /style does that just mean pull this branch locally? Or something else? Do you think I should just remove the tables for now?

@malcolmbarrett
Copy link
Collaborator

/style is supposed to activate our autostyler but it didn't work so I did it manually. But yes just pull this branch since I made changes on the remote

@malcolmbarrett
Copy link
Collaborator

I think the tables are useful but need to be pared down to the essentials

@LucyMcGowan
Copy link
Collaborator Author

are you ok with merging now and paring down in copy edits? or would you rather me reduce them prior -- if the latter, I'd love to chat about it first to figure out which parts you find the most useful!

@LucyMcGowan LucyMcGowan merged commit a95c481 into main Oct 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants