Don't import functions from miniUI, profvis, urlchecker (#2526)

Closes #2524
r-lib · Jul 12, 2023 · 2c642ab · 2c642ab
1 parent 9568e51
commit 2c642ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -85,15 +85,13 @@ importFrom(cli,cat_rule)
 importFrom(ellipsis,check_dots_used)
 importFrom(lifecycle,deprecated)
 importFrom(memoise,memoise)
-importFrom(miniUI,miniPage)
 importFrom(pkgbuild,clean_dll)
 importFrom(pkgbuild,find_rtools)
 importFrom(pkgbuild,has_devel)
 importFrom(pkgbuild,with_debug)
 importFrom(pkgload,check_dep_version)
 importFrom(pkgload,parse_deps)
 importFrom(pkgload,unload)
-importFrom(profvis,profvis)
 importFrom(remotes,dev_package_deps)
 importFrom(remotes,github_pull)
 importFrom(remotes,github_release)
@@ -112,7 +110,6 @@ importFrom(remotes,update_packages)
 importFrom(sessioninfo,package_info)
 importFrom(sessioninfo,session_info)
 importFrom(stats,update)
-importFrom(urlchecker,url_check)
 importFrom(usethis,ui_code)
 importFrom(usethis,ui_done)
 importFrom(usethis,ui_field)

diff --git a/R/devtools-package.R b/R/devtools-package.R
@@ -11,8 +11,12 @@
 
 ## usethis namespace: start
 #' @importFrom lifecycle deprecated
-#' @importFrom miniUI miniPage
-#' @importFrom profvis profvis
-#' @importFrom urlchecker url_check
 ## usethis namespace: end
 NULL
+
+# https://r-pkgs.org/dependencies-in-practice.html#how-to-not-use-a-package-in-imports
+ignore_unused_imports <- function() {
+  miniUI::miniPage
+  profvis::profvis
+  urlchecker::url_check
+}