Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-longer export inst() #2260

Merged
merged 2 commits into from
Sep 1, 2020
Merged

No-longer export inst() #2260

merged 2 commits into from
Sep 1, 2020

Conversation

hadley
Copy link
Member

@hadley hadley commented Jul 30, 2020

Fixes #2218

This will break a couple of packages, but they can just use pkgload::inst() instead (or system.file() in most cases)

@hadley hadley requested a review from jimhester July 30, 2020 18:52
@jimhester
Copy link
Member

jimhester commented Jul 30, 2020

Perhaps we should email these maintainers still using devtools::inst() now so that maybe they would update their packages and we could update devtools without manual CRAN intervention...

@hadley
Copy link
Member Author

hadley commented Jul 30, 2020

Looks like there are three packages — two are on Github and the last is archived:

I'll file issues.

@hadley
Copy link
Member Author

hadley commented Jul 30, 2020

Issues at IALSA/IalsaSynthesis#26 and LiveOak/NlsyLinks#1

@jimhester
Copy link
Member

Thanks!

@jimhester jimhester merged commit 5c7a300 into master Sep 1, 2020
@jimhester jimhester deleted the inst branch September 1, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider removing inst()
2 participants