Throw errors from mocked responses (#271)

Fixes #252

NEWS.md

@@ -1,5 +1,8 @@
 # httr2 (development version)
 
+* `with_mock()` and `local_mock()` now correctly trigger errors when the
+  mocked response represents an HTTP failure (#252).
+
 * New `req_progress()` adds a progress bar to long download or uploads (#20).
 
 * @mgirlich is now a httr2 contributor in recognition of many small contributions.

R/req-mock.R

@@ -22,7 +22,7 @@
 #' my_mock <- function(req) {
 #'   response(status_code = 403)
 #' }
-#' with_mock(my_mock, google())
+#' try(with_mock(my_mock, google()))
 with_mock <- function(mock, code) {
   withr::with_options(list(httr2_mock = mock), code)
 }

R/req-perform.R

@@ -62,7 +62,7 @@ req_perform <- function(
     mock <- as_function(mock)
     mock_resp <- mock(req)
     if (!is.null(mock_resp)) {
-      return(mock_resp)
+      return(handle_resp(req, mock_resp, error_call = error_call))
     }
   }
 
@@ -115,11 +115,15 @@ req_perform <- function(
   signal("", "httr2_fetch", n = n, tries = tries, reauth = reauth)
 
   resp <- cache_post_fetch(req, resp, path = path)
+  handle_resp(req, resp, error_call = error_call)
+}
 
+handle_resp <- function(req, resp, error_call = caller_env()) {
   if (is_error(resp)) {
     cnd_signal(resp)
   } else if (error_is_error(req, resp)) {
-    resp_abort(resp, error_body(req, resp), call = error_call)
+    body <- error_body(req, resp, error_call)
+    resp_abort(resp, body, call = error_call)
   } else {
     resp
   }

tests/testthat/test-req-mock.R

@@ -7,3 +7,10 @@ test_that("can override requests through mocking", {
   local_mock(~ resp)
   expect_equal(req_perform(req), resp)
 })
+
+test_that("can generate errors with mocking", {
+  local_mock(~ response(404))
+
+  req <- request("https://google.com")
+  expect_error(req_perform(req), class = "httr2_http_404")
+})