Default to no progress bar in tests (#541)

NEWS.md

@@ -1,5 +1,6 @@
 # httr2 (development version)
 
+* `req_perform()` no longer displays a progress bar when sleeping during tests. You can override this behaviour by setting the option `httr2_progress`.
 * `req_cache()` now re-caches the response if the body is hasn't been modified but the headers have changed (#442).
 * `req_cache()` works better when `req_perform()` sets a path (#442).
 * `req_body_*()` now give informative error if you attempt to change the body type (#451).

R/utils.R

@@ -43,11 +43,12 @@ modify_list <- function(.x, ..., error_call = caller_env()) {
 }
 
 
-sys_sleep <- function(seconds,
-                      task,
-                      fps = 10,
-                      progress = getOption("httr2_progress", TRUE)) {
+sys_sleep <- function(seconds, task, fps = 10, progress = NULL) {
   check_number_decimal(seconds)
+  check_string(task)
+  check_number_decimal(fps)
+  progress <- progress %||% getOption("httr2_progress", !is_testing())
+  check_bool(progress, allow_null = TRUE)
 
   if (seconds == 0) {
     return(invisible())

tests/testthat/_snaps/utils.md

@@ -6,10 +6,10 @@
       Error:
       ! All components of `...` must be named.
 
-# can suppress progress bar
+# progress bar suppressed in tests
 
     Code
-      sys_sleep(0.1, "for test")
+      sys_sleep(0.1, "in test")
     Message
-      > Waiting 1s for test
+      > Waiting 1s in test
 

tests/testthat/test-utils.R

@@ -29,8 +29,6 @@ test_that("respects httr verbose config", {
   expect_equal(httr2_verbosity(), 1)
 })
 
-test_that("can suppress progress bar", {
-  withr::local_options(httr2_progress = FALSE)
-
-  expect_snapshot(sys_sleep(0.1, "for test"))
+test_that("progress bar suppressed in tests", {
+  expect_snapshot(sys_sleep(0.1, "in test"))
 })