-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check with the oldest supported R version #1551
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@MichaelChirico Any thoughts on this? |
Is |
It's a requirement for GHA, but, IINM, that's the only way we have to know if things are working as expected on the older versions. Since CRAN doesn't test past oldrel-1. So I am not sure how we can confirm that we indeed support |
It's not too difficult to install 3.2 locally and test :) I am basically fine keeping the old version until it's proven not to work. OTOH, for lintr, its main use case is package development, and people submitting to CRAN are technically supposed to be testing their packages with r-devel. So it seems more reasonable to force newer versions of R, and an alignment to GHA makes sense if folks are relying on GHA to test versions of R unavailable to them locally during development. So, I'm fine either way. @AshesITR any thoughts? |
Okay, I am fine with that. I was just curious to hear your thoughts on this, apropos testing older R versions on GHA. |
The oldest R version we can check is
R 3.4
(r-lib/pak#417 (comment)).Given that we can't check on older R versions (or is there a way?) and thus can't confirm support for that R version either way, should we be bumping the minimum needed R version to
3.4
? (Currently, we supportR >= 3.2
.)