Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip extracted condition calls #2040

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Skip extracted condition calls #2040

merged 1 commit into from
Aug 4, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Closes #1455

@codecov-commenter
Copy link

Codecov Report

Merging #2040 (99df9da) into main (3e6b862) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 99df9da differs from pull request most recent head 6f348f5. Consider uploading reports for the commit 6f348f5 to get more accurate results

@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         114      114           
  Lines        5011     5013    +2     
=======================================
+ Hits         4939     4941    +2     
  Misses         72       72
Files Changed Coverage Δ
R/condition_message_linter.R 100.00% <100.00%> (ø)

@AshesITR AshesITR merged commit 239de20 into main Aug 4, 2023
21 checks passed
@AshesITR AshesITR deleted the cdn-msg-dol branch August 4, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AshesITR AshesITR AshesITR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive in condition_message_linter() for list$stop()
3 participants
@MichaelChirico @codecov-commenter @AshesITR