Address feedback from Reviewer-1 #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder whether the reviewer intends "description of other static code analysis packages" to be other R packages, or whether it should also branch out into what linting looks like for other languages. The difficulty of linting a dynamically-typed language / relative ease of doing so for a strongly typed one is interesting, not sure if it merits mention in this particular paper. Anyway, I did find two other linting packages on CRAN worth considering: https://cran.r-project.org/web/packages/box.linters/index.html |
Co-authored-by: Michael Chirico <[email protected]>
jimhester
reviewed
Sep 26, 2024
IndrajeetPatil
commented
Sep 26, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Co-authored-by: Michael Chirico <[email protected]>
MichaelChirico
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. openjournals/joss-reviews#7240 (comment)
Checking changes in
.Rmdwill be the easiest.