Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing character issue in JOSS's PDF output #2669

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing character issue in JOSS's PDF output #2669

wants to merge 1 commit into from

Conversation

IndrajeetPatil
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil commented Oct 3, 2024 •
edited
Loading

cf. openjournals/joss-reviews#7240 (comment)

On main, we see the following warnings:

Warning:  Missing character: There is no ℹ (U+2139) (U+2139) in font name:Hack/I:mode=node;script

These warnings no longer appear with this PR.

We can revert this change if openjournals/joss#963 is solved before the peer review concludes.

MichaelChirico
MichaelChirico approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but not submitting in case another fix (e.g. a more suitable font) is decided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IndrajeetPatil @MichaelChirico