Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgresql backend #82

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mattyb
Copy link

@mattyb mattyb commented Feb 13, 2019

This PR creates a PostgreSQL backend for memoise

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #82 into master will decrease coverage by 8.5%.
The diff coverage is 89.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   77.37%   68.86%   -8.51%     
==========================================
  Files           5        6       +1     
  Lines         221      318      +97     
==========================================
+ Hits          171      219      +48     
- Misses         50       99      +49
Impacted Files Coverage Δ
R/cache_postgresql.R 89.69% <89.69%> (ø)
R/cache_s3.R 0% <0%> (-100%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1650ad7...86c6a6c. Read the comment docs.

@jimhester
Copy link
Member

Is there a reason you used RPostgreSQL for this instead of RPostgres? Also rather than a postgres specific database maybe it would make more sense to use the odbc package, so any odbc-compliant database could be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants