Simpler approaching to removing call suffix #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
force-pushed
the
simpler_suffix
branch
from
b913406
to
dab2351
Compare
lionel-
approved these changes
Sep 17, 2024
R/profvis.R
Outdated
|
|
||
| # Use unique name so we can easily trim below |
There was a problem hiding this comment.
Probably needs some comments about why we use new_function() here. This is hard to explain but here is an attempt:
The goal is for the quoted expression to be directly called by a function that we can detect in both raw and simplified stack traces. In the simplified case, it's important for the function to directly call the profiled code and not just force a promise containing it, since in that case the sentinel function gets simplified away.
There was a problem hiding this comment.
Also need to document the behaviour change that we now evaluate in a child of env.
wch
reviewed
Sep 17, 2024
| @@ -1,5 +1,6 @@ | |||
| # profvis (development version) | |||
|
|
|||
| * New technique for trimming uninteresting frames from the stack (#130). This requires a new evaluationg model where the code you supply to `profvis()` is turned into the body of a zero-argument anonymous function that is then called by profvis. This subtly changes the semantics of evaluation, but it's very unlikely to affect the type of code that you are typically profiling. | |||
There was a problem hiding this comment.
Suggested change
| * New technique for trimming uninteresting frames from the stack (#130). This requires a new evaluationg model where the code you supply to `profvis()` is turned into the body of a zero-argument anonymous function that is then called by profvis. This subtly changes the semantics of evaluation, but it's very unlikely to affect the type of code that you are typically profiling. | |
| * New technique for trimming uninteresting frames from the stack (#130). This requires a new evaluation model where the code you supply to `profvis()` is turned into the body of a zero-argument anonymous function that is then called by profvis. This subtly changes the semantics of evaluation, but it's very unlikely to affect the type of code that you are typically profiling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130