-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty lines between roxygen comments and code #948
Remove empty lines between roxygen comments and code #948
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Great start @IndrajeetPatil always good to start with a skeleton and a test. I’d just put |
Ah and before we forget: at the end, we should also add a transformer drop rule. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if cee1f3e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if f48eddf is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Codecov Report
@@ Coverage Diff @@
## main #948 +/- ##
=======================================
Coverage 91.06% 91.07%
=======================================
Files 46 46
Lines 2687 2689 +2
=======================================
+ Hits 2447 2449 +2
Misses 240 240
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if ebea03e is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
@IndrajeetPatil do you merge manually? I keep getting notifications and I think I don’t want them I until this is ready for review. Converting to draft now. |
I will actually just close this for now, since there is no value in this PR before including any functionality. |
@lorenzwalthert Creating a draft PR while I figure out the implementation.
As mentioned in #936, I will definitely need some help figuring out a few things since I am not sure if I follow the code logic yet. Will post more concrete questions here as I work through the implementation.