Finish off #2046

* Add news bullet * Add explanatory comment
r-lib · Jan 8, 2025 · 690fdb8 · 690fdb8
1 parent a3cb74d
commit 690fdb8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # testthat (development version)
 
+* Fixed an issue where `expect_no_error(1)` was failing (#2037).
+
 * Fixed an issue where calling `skip()` outside of an active test could
   cause an unexpected error (@kevinushey, #2039).
 

diff --git a/R/expect-no-condition.R b/R/expect-no-condition.R
@@ -98,6 +98,8 @@ expect_no_ <- function(base_class,
     try_fetch(
       {
         code
+        # We can't call succeed() here because that generates a condition
+        # that causes `expect_no_condition()` to always fail
         NULL
       },
       !!base_class := function(cnd) {