add fix for skip outside test

r-lib · Dec 11, 2024 · fbf53ae · fbf53ae
1 parent dbe8883
commit fbf53ae
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # testthat (development version)
 
+* Fixed an issue where calling `skip()` outside of a test could cause
+  an unexpected error (@kevinushey, #2038).
+
 # testthat 3.2.2
 
 ## New expectations

diff --git a/R/snapshot-reporter.R b/R/snapshot-reporter.R
@@ -116,7 +116,7 @@ SnapshotReporter <- R6::R6Class("SnapshotReporter",
     },
 
     add_result = function(context, test, result) {
-      if (is.null(self$test)) {
+      if (!length(self$test)) {
         return()
       }