Use autoconf to generate Makevars at install time #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is failing on windows. I know the error, I got it in another package and I remember I had a lot of trouble figuring out how to fix it. Sadly I do not remember the procedure. |
|
hmmmmm. I don't have super convenient access to a windows cpu to debug this. How can I find the logs for these runs? |
|
The solution is there, I remember: R-ArcGIS/arcgisutils@17b2520#diff-618cd5b83d62060ba3d027e314a21ceaf75d36067ff820db126642944145393eR4 |
|
jeez, how silly. Thanks for finding that fix! Rebased, give it a look when you can please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
configurescript to the package, which will generate Makevar files when the package is installed. Theconfigurescript is generated by GNU autoconf fromconfigure.ac, and must be regenerated by the developer whenconfigure.acis modified.This PR also adds a
cleanupscript, which R will use to remove the files thatconfigurewill generate.Resolves #786
References: