Speed up by using '--skip-loading-plugins' in specific 'qgis_process' calls #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some (yet unkown) conditions the 'processing' plugin can appear as disabled; yet its algorithms remain available to qgis_process (see Details section of qgis_enable_plugins() docs). This has been noted in macOS, Windows, and Ubuntu, but not in each GHA workflow setup. The fact that this comes up after the implementation of skipping loaded plugins may mean that --skip-loading-plugins interferes with the 'processing' plugin being enabled or not. As long this poses no critical problem in R, no further investigation is needed here. In a few GHA jobs this pops up as if no processing providers are enabled, which fails a few expectations. Hence dropping these (actually unneeded) expectations (about counting number of enabled plugins) so that the 'processing' plugin artifact is no party-stopper.
|
The remaining failing checks on Windows are as expected: currently {terra} fails to install on R-devel. I'll ignore this since it will probably be fixed in {terra}. However planning to also fix #210 here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201.
Depending on the number of installed processing provider plugins, the speed gain can be considerable!