Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests, update contributors, prepare release #212

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

polettif
Copy link
Contributor

@polettif polettif commented Dec 7, 2023

Prepare release 1.6.1. The package is on its way to CRAN now.

  • updated list of contributors in description
  • removed/replaced deprecated testthat functions
  • skip all tests on CRAN which read the nyc dataset
  • Fix multi-thread data.table tests for CRAN on Debian

Resolving the following note was IMO unnecessary convoluted:

* checking tests ... [62s/8s] NOTE
  Running ‘testthat.R’ [62s/8s]
Running R code in ‘testthat.R’ had CPU time 7.9 times elapsed time

I found a solution here: Rdatatable/data.table#5658 as @eddelbuettel stated

package authors who each have to learn the 'how to do this' one by one

definitely applies here.

@@ -1,3 +1,4 @@
data.table::setDTthreads(2)
Copy link

@eddelbuettel eddelbuettel Dec 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that is good as it covers all tests globally. You could play additional dances and condition on 'knowable' states (e.g. if (Sys.info()[["sysname"]]=="Linux) may make sense) but this should work.

(Oh, and just to state the obvious in case there was any doubt: I disagree strongly with this Policy requirement but my few posts on the package development list have clearly not changed anybody's mind at CRAN so the above is chiefly a coping mechanism.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok 👍 thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, it was quite clear that you disagree with the policy decision.

I don't know enough about multithreading packages myself but I don't find the arguments made by CRAN in the R-pkg-devel list that I skimmed to be all that convincing. The way the policy is enforced however (I just learned of it because I wanted to push a really minor fix to CRAN) is, let's say, not ideal. So at this point, any coping mechanism is fine by me, I just wanted to get the package up again.

@polettif polettif merged commit 5341a06 into master Dec 7, 2023
5 checks passed
@polettif polettif deleted the dev/prepare-release branch December 7, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants