Fix after code review.

r-world-devs · Dec 19, 2024 · b85ed50 · b85ed50
1 parent b621cab
commit b85ed50
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/R/EngineGraphQLGitLab.R b/R/EngineGraphQLGitLab.R
@@ -127,7 +127,6 @@ EngineGraphQLGitLab <- R6::R6Class(
                                   repos,
                                   file_paths = NULL,
                                   host_files_structure = NULL,
-                                  only_text_files,
                                   verbose = FALSE,
                                   progress = FALSE) {
       org <- URLdecode(org)
@@ -139,7 +138,7 @@ EngineGraphQLGitLab <- R6::R6Class(
           host_files_structure = host_files_structure,
           org = org
         )
-      } else if (only_text_files) {
+      } else {
         file_paths <- file_paths[grepl(text_files_pattern, file_paths)]
       }
       if (type == "organization") {
@@ -177,7 +176,6 @@ EngineGraphQLGitLab <- R6::R6Class(
                 repos = repos,
                 file_paths = file_paths,
                 host_files_structure = host_files_structure,
-                only_text_files = only_text_files,
                 verbose = verbose,
                 progress = progress
               )
@@ -219,7 +217,6 @@ EngineGraphQLGitLab <- R6::R6Class(
           repos = repos,
           file_paths = file_paths,
           host_files_structure = host_files_structure,
-          only_text_files = only_text_files,
           verbose = verbose,
           progress = progress
         )
@@ -235,7 +232,6 @@ EngineGraphQLGitLab <- R6::R6Class(
                                            repos,
                                            file_paths = NULL,
                                            host_files_structure = NULL,
-                                           only_text_files = TRUE,
                                            verbose = FALSE,
                                            progress = FALSE) {
       if (is.null(repos)) {

diff --git a/tests/testthat/test-get_files_content-GitLab.R b/tests/testthat/test-get_files_content-GitLab.R
@@ -60,7 +60,6 @@ test_that("GitLab GraphQL Engine pulls files from a group", {
     type = "organization",
     repos = NULL,
     file_paths = "meta_data.yaml",
-    only_text_files = TRUE,
     host_files_structure = NULL
   )
   expect_gitlab_files_from_org_response(gitlab_files_response)
@@ -123,7 +122,6 @@ test_that("Gitlab GraphQL switches to pulling files per repositories when query
     repos = NULL,
     file_paths = c("project_metadata.yaml", "README.md"),
     host_files_structure = NULL,
-    only_text_files = TRUE,
     verbose = FALSE,
     progress = FALSE
   )