Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

231 fix language functionality #265

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Conversation

maciekbanas
Copy link
Member

No description provided.

@maciekbanas maciekbanas requested a review from Cotau August 9, 2023 11:30
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2023

Codecov Report

Patch coverage: 73.89% and project coverage change: +2.34% 🎉

Comparison is base (1081673) 75.40% compared to head (d98b118) 77.75%.
Report is 68 commits behind head on devel.

❗ Current head d98b118 differs from pull request most recent head a047d98. Consider uploading reports for the commit a047d98 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #265      +/-   ##
==========================================
+ Coverage   75.40%   77.75%   +2.34%     
==========================================
  Files          12       14       +2     
  Lines         992     1353     +361     
==========================================
+ Hits          748     1052     +304     
- Misses        244      301      +57     
Files Changed Coverage Δ
R/plots.R 0.00% <0.00%> (ø)
R/GitHost.R 55.43% <47.36%> (+10.53%) ⬆️
R/test_helpers.R 75.00% <62.50%> (-8.34%) ⬇️
R/EngineRestGitLab.R 83.98% <77.27%> (-1.87%) ⬇️
R/EngineRestGitHub.R 77.38% <84.51%> (+4.15%) ⬆️
R/EngineGraphQLGitLab.R 92.30% <92.30%> (ø)
R/EngineGraphQLGitHub.R 83.98% <92.68%> (-0.29%) ⬇️
R/GQLQueryGitLab.R 97.67% <97.67%> (ø)
R/EngineGraphQL.R 100.00% <100.00%> (ø)
R/EngineRest.R 93.33% <100.00%> (-0.32%) ⬇️
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Cotau Cotau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would just change NULL parameter to some string saying "all" to be more intuitive

@maciekbanas maciekbanas merged commit 88d102c into devel Aug 10, 2023
3 of 4 checks passed
@maciekbanas maciekbanas deleted the 231-fix-language-functionality branch August 10, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants