258 let whole internal git platform be scanned #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of major adjustments was moving `check_organizations` and initialize methods to EngineRest superclass. Also error handling of wrong inputs to `set_connection` on `GitStats` level was removed for the sake of simplicity and making neat messages to user.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## devel #274 +/- ##
==========================================
- Coverage 75.40% 75.18% -0.22%
==========================================
Files 12 14 +2
Lines 992 1491 +499
==========================================
+ Hits 748 1121 +373
- Misses 244 370 +126
☔ View full report in Codecov by Sentry. |
…te over all orgs but use search endpoint on whole git platform (override orgs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding possibility to scan all git platforms by:
... with few code optimizations:
setup_engines) and adding some helpers (set_host,check_if_public)initializeandcheck_organizations) from Engine Rest subclasses to the superclass,GitStats(improving messages to user).