Update rlang. #288
Merged
Update rlang. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinkowskak
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
I was able to install the package, locally packages were updated with renv without issues and checks went ok.
Example workflow works as expected but you may want to limit some dates so the code executes faster.
One minor thing maybe - when loading new session and calling library(GitStats) I still need to load magrittr manually so it would be a good idea to import pipe to the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karolina @marcinkowskak you can review the PR with installing
GitStatsfrom this branch and going through example workflow, checking if all stays the same as before.