Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

413 399 415 improve set hosts #416

Merged
merged 4 commits into from
May 9, 2024
Merged

413 399 415 improve set hosts #416

merged 4 commits into from
May 9, 2024

Conversation

maciekbanas
Copy link
Member

Improve setting hosts:

  • control verbose for set_*_host() functions.
  • throw error when wrong host is passed.

@maciekbanas maciekbanas self-assigned this May 9, 2024
marcinkowskak
marcinkowskak approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@marcinkowskak marcinkowskak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! :) Only one possible spellcheck found:

< Potential spelling errors:
  <   WORD      FOUND IN
  < speeded   NEWS.md:3

@maciekbanas maciekbanas merged commit 6d4912f into devel May 9, 2024
2 checks passed
@maciekbanas maciekbanas deleted the 413-399-415-improve-set_hosts branch May 9, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcinkowskak marcinkowskak marcinkowskak approved these changes

Assignees

@maciekbanas maciekbanas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciekbanas @marcinkowskak