Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

555 fix pulling GitHub commits #558

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Conversation

maciekbanas
Copy link
Member

  • handle GraphQL errors
  • repeat request on 502 error (if httr2 retry does not work)
  • fix building table out of commits output
  • move repo cursor from query vars to function parameter

…retry and fix preparing table output when login is empty. Passing empty `repo_cursor` ('') as variable to GraphQL request works for public GitHub but not necessarily for private platforms. The suggested solution will work for both.
@maciekbanas maciekbanas self-assigned this Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 84.09091% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.39%. Comparing base (b5907c3) to head (19a7a97).
Report is 6 commits behind head on devel.

Files with missing lines Patch % Lines
R/EngineGraphQLGitHub.R 80.55% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #558      +/-   ##
==========================================
- Coverage   75.46%   75.39%   -0.08%     
==========================================
  Files          17       17              
  Lines        3200     3219      +19     
==========================================
+ Hits         2415     2427      +12     
- Misses        785      792       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maciekbanas maciekbanas merged commit a0dc1ec into devel Dec 9, 2024
8 checks passed
@maciekbanas maciekbanas deleted the 555-fix-pulling-github-commits branch December 9, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants