Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting search scope to both orgs and repositories #561

Merged
merged 27 commits into from
Dec 20, 2024

Conversation

maciekbanas
Copy link
Member

@maciekbanas maciekbanas commented Dec 13, 2024

Closes #400

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 78.92216% with 176 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (cfa5b79) to head (88ed0d6).
Report is 29 commits behind head on devel.

Files with missing lines Patch % Lines
R/GitHost.R 85.96% 65 Missing ⚠️
R/GitHostGitLab.R 62.83% 42 Missing ⚠️
R/EngineRestGitHub.R 58.97% 32 Missing ⚠️
R/GitHostGitHub.R 77.04% 14 Missing ⚠️
R/gitstats_functions.R 0.00% 10 Missing ⚠️
R/GitStats.R 57.14% 6 Missing ⚠️
R/EngineRestGitLab.R 92.72% 4 Missing ⚠️
R/EngineGraphQLGitLab.R 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #561      +/-   ##
==========================================
+ Coverage   75.73%   81.04%   +5.31%     
==========================================
  Files          18       18              
  Lines        3219     3620     +401     
==========================================
+ Hits         2438     2934     +496     
+ Misses        781      686      -95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…raphQL requests, fixing and adjusting tests. In tests there was a need to change order of test calls: first should go repos, then commits, as get_repos_names was moved to tests for commits (from releases).
…lling data from repos (when org is a user), change name of get_repos_individual to get_repos_from_repos, fix pulling releases when empty.
…bility to pull non-text files, fix pagination when pulling GitLab files from org, some changes in style. In case of pagination NULL values were assinged to hasNextPage and endCursor. In case of removing possibility to pull content of non-text files - it seemed superfluous, made code very complex with custom methods for GitLab nota bene new REST method only for pulling content of non-text files (!). Pulling content should not end in pulling no content.
@maciekbanas maciekbanas self-assigned this Dec 17, 2024
@maciekbanas maciekbanas marked this pull request as ready for review December 19, 2024 12:46
Copy link
Collaborator

@marcinkowskak marcinkowskak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Maciej! It looks really good :)

@maciekbanas maciekbanas merged commit f16a1cd into devel Dec 20, 2024
8 checks passed
@maciekbanas maciekbanas deleted the 400-allow-define-orgs-and-repos-in-set_host branch December 20, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants