42 cohort methods test #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e(), eval_step_filters(), next_step()
galachad
requested changes
Dec 20, 2024
| expect_equal(steps_range(3,2),character(0)) | ||
| }) | ||
|
|
||
| test_that("eval_step_filters from Step.R returns empty character when step id is equal", { |
There was a problem hiding this comment.
We should not specify file name, usually using function name is enoght.
Suggested change
| test_that("eval_step_filters from Step.R returns empty character when step id is equal", { | |
| test_that("eval_step_filters returns empty character when step id is equal", { |
| @@ -831,6 +831,19 @@ test_that("Defining and accessing description works fine", { | |||
| ) | |||
| }) | |||
|
|
|||
| test_that("steps_range from Step.R returns empty character when from is greater than to", { | |||
There was a problem hiding this comment.
Suggested change
| test_that("steps_range from Step.R returns empty character when from is greater than to", { | |
| test_that("steps_range returns empty character when from is greater than to", { |
|
|
||
| test_that("pair_seq requires an even number of indexes", { | ||
| # If odd length input is provided, function should fail due to indexing error | ||
| expect_error(pair_seq(c(1, 2, 3))) |
There was a problem hiding this comment.
expect_error function can use regex, for check an error, worth to verify if it make sense to use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover steps test for #42