Merge pull request #37 from r-world-devs/v0.4.2

v0.4.2
r-world-devs · Mar 1, 2023 · 490d7c7 · 490d7c7
2 parents c166fc9 + bfc8dee
commit 490d7c7
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 11 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: shinyGizmo
 Title: Custom Components for Shiny Applications
-Version: 0.4.1
+Version: 0.4.2
 Authors@R: c(
     person("Krystian", "Igras", , "[email protected]", role = c("cre", "aut")),
     person("Adam", "Foryś", role = "ctb"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,7 @@
+# shinyGizmo 0.4.2
+
+* Fix handling non-existing selector case for valueButton.
+
 # shinyGizmo 0.4.1
 
 * `textArea` now stores its id as `data-id` attribute. This prevents automatic binding of the element by shiny library.

diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 
 # shinyGizmo
 
-[![version](https://img.shields.io/static/v1.svg?label=github.com&message=v.0.4.1&color=ff69b4)](https://img.shields.io/static/v1.svg?label=github.com&message=v.0.1&color=ff69b4)
+[![version](https://img.shields.io/static/v1.svg?label=github.com&message=v.0.4.2&color=ff69b4)](https://img.shields.io/static/v1.svg?label=github.com&message=v.0.1&color=ff69b4)
 [![lifecycle](https://img.shields.io/badge/lifecycle-stable-success.svg)](https://lifecycle.r-lib.org/articles/stages.html#stable)
 
 ## Overview
@@ -11,7 +11,7 @@ applications.
 
 <center>
 
-## <span style="color:blue"> shinyGizmo 0.4.1 is now available!</span>
+## <span style="color:blue"> shinyGizmo 0.4.2 is now available!</span>
 
 </center>
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -4,15 +4,18 @@
 * win-builder
   R version 4.1.3 (2022-03-10)
   R version 4.2.2 (2022-10-31 ucrt)
-  R Under development (unstable) (2023-02-23 r83894 ucrt)
+  R Under development (unstable) (2023-02-27 r83911 ucrt)
 
-## `R CMD check shinyGizmo_0.4.1.tar.gz --as-cran` results
+## `R CMD check shinyGizmo_0.4.2.tar.gz --as-cran` results
 
 ```
 * using log directory ‘/home/krystian/projects/shinyGizmo.Rcheck’
 * using R version 4.2.1 (2022-06-23)
 * using platform: x86_64-pc-linux-gnu (64-bit)
 ...
+* checking CRAN incoming feasibility ... NOTE
+Maintainer: 'Krystian Igras <[email protected]>'
+...
 Status: OK
 ```
 
@@ -46,19 +49,19 @@ The word "UI" intentionally used.
 * using R version 4.2.2 (2022-10-31 ucrt)
 * using platform: x86_64-w64-mingw32 (64-bit)
 ...
-* checking CRAN incoming feasibility ... Note_to_CRAN_maintainers
+* checking CRAN incoming feasibility ... NOTE
 Maintainer: 'Krystian Igras <[email protected]>'
 ...
-Status: OK
+Status: 1 NOTE
 ```
 
 ```
 * using log directory 'd:/RCompile/CRANguest/R-devel/shinyGizmo.Rcheck'
-* using R Under development (unstable) (2023-02-23 r83894 ucrt)
+* using R Under development (unstable) (2023-02-27 r83911 ucrt)
 * using platform: x86_64-w64-mingw32 (64-bit)
 ...
-* checking CRAN incoming feasibility ... [10s] Note_to_CRAN_maintainers
+* checking CRAN incoming feasibility ... [15s] NOTE
 Maintainer: 'Krystian Igras <[email protected]>'
 ...
-Status: OK
+Status: 1 NOTE
 ```
diff --git a/inst/www/valuebutton.js b/inst/www/valuebutton.js
@@ -34,7 +34,7 @@ $.extend(valueButtonBinding, {
     if (selector == "document") {
       $target = document;
     }
-    if (!!$target) {
+    if (!$target) {
       return;
     }
     if ($(el).data("try_binding") == "TRUE") {