Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wallet integration #371

Merged
merged 26 commits into from
Dec 19, 2024

test: improve `crates/pop-cli/src/common/contracts.rs` coverage (#391)

ae7b3a2
Select commit
Loading
Failed to load commit list.
Merged

feat: wallet integration #371

test: improve `crates/pop-cli/src/common/contracts.rs` coverage (#391)
ae7b3a2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 18, 2024 in 1s

75.10% (-0.54%) compared to e1bfbc8

View this Pull Request on Codecov

75.10% (-0.54%) compared to e1bfbc8

Details

Codecov Report

Attention: Patch coverage is 64.15094% with 399 lines in your changes missing coverage. Please review.

Project coverage is 75.10%. Comparing base (e1bfbc8) to head (ae7b3a2).

Files with missing lines Patch % Lines
crates/pop-cli/src/commands/up/contract.rs 41.77% 111 Missing and 20 partials ⚠️
crates/pop-contracts/src/up.rs 52.34% 58 Missing and 13 partials ⚠️
crates/pop-cli/src/commands/call/chain.rs 44.59% 36 Missing and 5 partials ⚠️
crates/pop-cli/src/commands/call/contract.rs 62.50% 35 Missing and 4 partials ⚠️
crates/pop-contracts/src/call.rs 3.03% 32 Missing ⚠️
crates/pop-cli/src/common/wallet.rs 12.90% 26 Missing and 1 partial ⚠️
crates/pop-cli/src/common/contracts.rs 71.18% 5 Missing and 12 partials ⚠️
crates/pop-parachains/src/call/mod.rs 11.11% 16 Missing ⚠️
crates/pop-cli/src/wallet_integration.rs 96.13% 9 Missing and 6 partials ⚠️
crates/pop-cli/src/commands/test/contract.rs 0.00% 6 Missing ⚠️
... and 2 more 
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   75.64%   75.10%   -0.54%     
==========================================
  Files          59       61       +2     
  Lines       12715    13701     +986     
  Branches    12715    13701     +986     
==========================================
+ Hits         9618    10290     +672     
- Misses       1801     2056     +255     
- Partials     1296     1355      +59
Files with missing lines Coverage Δ
crates/pop-cli/src/cli.rs 65.46% <ø> (ø)
crates/pop-cli/src/main.rs 43.24% <ø> (ø)
crates/pop-contracts/src/utils/metadata.rs 91.27% <100.00%> (ø)
crates/pop-parachains/src/call/metadata/mod.rs 93.15% <100.00%> (ø)
crates/pop-common/src/lib.rs 74.50% <87.50%> (+0.59%) ⬆️
crates/pop-contracts/src/node.rs 66.25% <80.00%> (ø)
crates/pop-cli/src/commands/test/contract.rs 0.00% <0.00%> (ø)
crates/pop-cli/src/wallet_integration.rs 96.13% <96.13%> (ø)
crates/pop-parachains/src/call/mod.rs 57.73% <11.11%> (-6.32%) ⬇️
crates/pop-cli/src/common/contracts.rs 59.05% <71.18%> (+35.05%) ⬆️
... and 6 more
View more details on Codecov