Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(wallet-integration): remove sign_call_data test #384

Merged

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Dec 16, 2024

Re applying changes in f9851d1 based on the conversations had during #382.

@al3mart al3mart requested review from AlexD10S and peterwht December 16, 2024 12:23
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for solving this

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (peter/feat-wallet-integration@6b13134). Learn more about missing BASE report.

@@                       Coverage Diff                        @@
##             peter/feat-wallet-integration     #384   +/-   ##
================================================================
  Coverage                                 ?   75.00%           
================================================================
  Files                                    ?       61           
  Lines                                    ?    13640           
  Branches                                 ?    13640           
================================================================
  Hits                                     ?    10231           
  Misses                                   ?     2064           
  Partials                                 ?     1345           
Files with missing lines Coverage Δ
crates/pop-cli/src/common/wallet.rs 0.00% <ø> (ø)

Copy link
Contributor

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@peterwht peterwht merged commit 7227abc into peter/feat-wallet-integration Dec 17, 2024
15 checks passed
@peterwht peterwht deleted the al3mart/chore-remove-sign-call-data branch December 17, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants