Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve coverage #391

Merged
merged 9 commits into from
Dec 18, 2024
Merged

test: improve coverage #391

merged 9 commits into from
Dec 18, 2024

Conversation

al3mart
Copy link
Contributor

@al3mart al3mart commented Dec 18, 2024 •
edited
Loading

Improves coverage for

  • terminate_node
  • check_contracts_node_and_prompt

In pop-cli/common/contracts.rs

Refactors a few functions so that they receive the Cli as a parameter following the changes in #315 to facilitate testing.

@al3mart al3mart requested review from AlexD10S and peterwht December 18, 2024 21:33
peterwht
peterwht requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just one small sentence change please :)

crates/pop-cli/src/common/contracts.rs Outdated Show resolved Hide resolved
@AlexD10S AlexD10S self-requested a review December 18, 2024 22:04
AlexD10S
AlexD10S requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one very small point, update the docs in check_contracts_node_and_prompt with the new arguments

AlexD10S
AlexD10S approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this changes!

@al3mart al3mart merged commit ae7b3a2 into peter/feat-wallet-integration Dec 18, 2024
2 of 3 checks passed
@al3mart al3mart deleted the al3mart/test-improve-coverage branch December 18, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterwht peterwht peterwht approved these changes

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@al3mart @AlexD10S @peterwht