Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Book Club Meeting Slides for Ch 1 and Ch 2 #2

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

jellisfw
Copy link
Contributor

Initial Content for 2024-07-24 Chapters 1 and 2. This will likely update or have additional data added during the meeting itself.

jonthegeek
jonthegeek previously approved these changes Jul 24, 2024
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this (after I commit a change), but I encourage you to make slides fit on one page without scrolling. We'll hopefully convert everything to a quarto presentation relatively soon, and those long slides will be officially weird once we do (the text will go off the bottom of the slide with no way to view it).

DESCRIPTION Outdated Show resolved Hide resolved
Copy link
Member

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving with typo-package removed.

@jonthegeek jonthegeek enabled auto-merge (squash) July 24, 2024 12:53
@jonthegeek jonthegeek disabled auto-merge July 24, 2024 12:53
@jonthegeek jonthegeek enabled auto-merge (squash) July 24, 2024 12:53
@jonthegeek jonthegeek merged commit d12d6bb into r4ds:main Jul 24, 2024
1 check passed
@jellisfw
Copy link
Contributor Author

@jonthegeek thanks for feedback and approval. For the multiple page slides, when going through the site with this pushed in it, the content appeared all there. Is there a different location that it would cut the slides off. Is "one page" considered as long as I do not have to scroll or is there a set number of lines stated? Thank you

@jonthegeek
Copy link
Member

@jonthegeek thanks for feedback and approval. For the multiple page slides, when going through the site with this pushed in it, the content appeared all there. Is there a different location that it would cut the slides off. Is "one page" considered as long as I do not have to scroll or is there a set number of lines stated? Thank you

It won't be cut off today, but it will be in the "true slides" quarto upgrade that's coming soonish. It's hard to say exactly what will fit, because it depends on how much is code, spacing, etc. Just try to keep it feeling "slide like."

HOPEFULLY I can implement the upgrade soon to make it easier to grok what I'm talking about 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants