capitalize the first character of component name #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for saving my time! |
Yaronglp
reviewed
Dec 6, 2022
| @@ -22,7 +22,7 @@ | |||
| "", | |||
| "type State = {}", | |||
| "", | |||
| "export default class ${1:${TM_FILENAME_BASE}} extends Component<Props, State> {", | |||
| "export default class ${1:${TM_FILENAME_BASE/(.*)/${1:/capitalize}/}} extends Component<Props, State> {", | |||
There was a problem hiding this comment.
You made a great change, but what would happen if I want to push another snippet? or if I will have another request for changes on the component's name?
I think we can optimize it.
I'm suggesting formatting the component name only in one place and reusing that place.
i.e, use the TM_FILENAME_BASE and capitalize it before using it on the generated.json.
Then you will do all your changes in one place and only once, instead of repeating the logic for every snippet.
what do you say?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#271