-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update readme for v0.1.0 setup and models #130
base: master
Are you sure you want to change the base?
update readme for v0.1.0 setup and models #130
Conversation
- [DeepVoice3: Multi-speaker text-to-speech demo](https://colab.research.google.com/github/r9y9/Colaboratory/blob/master/DeepVoice3_multi_speaker_TTS_en_demo.ipynb) | ||
- [DeepVoice3: Single-speaker text-to-speech demo](https://colab.research.google.com/github/r9y9/Colaboratory/blob/master/DeepVoice3_single_speaker_TTS_en_demo.ipynb) | ||
|
||
## Installation and test of version v0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the script is worth putting it to the README. Setup procedure depends on envinronments where people work.
What about making your own gist for the script and put the link to the trouble shooting or a new section (e.g., Examples)?
Also, if you like self-contained shell script that runs everything to prepare end-to-end TTS models, it might be useful to create Docerfile instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that at least the part:
pip install numpy # Required because nnmnkwii setup has it as dependency and else pip install nnmnkwii (within next command) fails
pip install -e ".[bin]"
pip install matplotlib # This is not installed by previous command. Maybe it should be added to the bin target
pip install tensorflow # No special nn routines are used. A proposed patch gets rid of this requirement
python -c "import nltk; nltk.download('cmudict')"
python -c "import nltk; nltk.download('punkt')"
should be included.
To me at least it is confusing when I follow the requirements described in a readme, start executing the code and then get errors over and over again, having to "decipher" each one, researching what is missing, and having to install it.
So I appreciate and exhaustive requirements or install list.
The rest was information on how the models were trained and how they worked. I actually trained them with those commands.
Also, I will consider your gist suggestion, but go ahead for now merging only the additions you feel appropriate.
| [link](https://drive.google.com/open?id=1FauMlx2OPpVC5cSgdfT86_eWJksCfd2C) | DeepVoice3 | LJSpeech 1.1 | presets/deepvoice3_ljspeech.json | [v0.1.0](https://github.com/r9y9/deepvoice3_pytorch/tree/v0.1.0) | 1000k | | ||
| [link](https://drive.google.com/open?id=1eZglEroWcU5-HpRwjebNGRDp_CEfQxUe) | Nyanko | LJSpeech 1.1 | presets/nyanko_ljspeech.json | [v0.1.0](https://github.com/r9y9/deepvoice3_pytorch/tree/v0.1.0) | 1000k | | ||
|
||
These models were trained by @Martin-Laclaustra at the Supercomputing Centre of Aragon / Centro de Supercomputación de Aragón [(CESAR)](http://cesar.unizar.es/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The title says it all.