Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PasswordHash in User type #886

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Support PasswordHash in User type #886

merged 7 commits into from
Sep 30, 2024

Commits on Sep 23, 2024

  1. Read password hash from User's importCredentialSecret 

    If `passwordHash` field is set, then `password` field is ignored and the resulting credential secret will contain only the hash. A passwordless user is created if the hash is an empty string.
    @NikSays
    NikSays committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a067b61 View commit details
    Browse the repository at this point in the history

  2. Add hash-based User creation system tests 

    1. Create a User with a hash and verify that the user exists, and can be authenticated.
2. Create a User with an empty hash and verify that the password was ignored, the user exists, and cannot be authenticated.
    @NikSays
    NikSays committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5af4f43 View commit details
    Browse the repository at this point in the history

  3. Check for empty username in ImportCredentialsSecret 

    Unset username was handled correctly, but empty username resulted in an unclear error: "Error 405 (Error 405 from RabbitMQ: EOF):".
    @NikSays
    NikSays committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c40ae34 View commit details
    Browse the repository at this point in the history

  4. Move UsersCredentials struct to the internal package 

    Rename user_settings.go to user.go to reflect its extended scope
    @NikSays
    NikSays committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    c4c04b5 View commit details
    Browse the repository at this point in the history

  5. Add unit test for hash-based GenerateUserSettings

    @NikSays
    NikSays committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    b315eaf View commit details
    Browse the repository at this point in the history

  6. Add examples for hash-based User creation 

    userWithPasswordHash.yaml - Creating a User with SHA-512 hash.
passwordlessUser.yaml - Creating a User with empty hash. Password field is ignored, paswordless user is created.
    @NikSays
    NikSays committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    58d496c View commit details
    Browse the repository at this point in the history

  7. Update UserSpec documentation 

    Describe the new structure of the `importCredentialsSecret` field
    @NikSays
    NikSays committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    138c602 View commit details
    Browse the repository at this point in the history