Merge pull request #1709 from danielmarbach/try-add

Safeguarding against duplicate sequence numbers
rabbitmq · Oct 23, 2024 · e51f6bc · e51f6bc
2 parents 43da301 + 9163bcc
commit e51f6bc
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/projects/RabbitMQ.Client/Impl/Channel.PublisherConfirms.cs b/projects/RabbitMQ.Client/Impl/Channel.PublisherConfirms.cs
@@ -295,7 +295,10 @@ await _confirmSemaphore.WaitAsync(cancellationToken)
                 if (_publisherConfirmationTrackingEnabled)
                 {
                     publisherConfirmationTcs = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
-                    _confirmsTaskCompletionSources[publishSequenceNumber] = publisherConfirmationTcs;
+                    if (!_confirmsTaskCompletionSources.TryAdd(publishSequenceNumber, publisherConfirmationTcs))
+                    {
+                        throw new InvalidOperationException($"Failed to track the publisher confirmation for sequence number '{publishSequenceNumber}' because it already exists.");
+                    }
                 }
 
                 _nextPublishSeqNo++;