Remove more synchronous code #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of the fix to #1472 * Remove `ISession.Transmit` * Change `HeartbeatWriteTimerCallback` to be `async` and use `WriteAsync` * Make `HeartbeatReadTimerCallback` async * Ensure toxiproxy is reset at the end of the test run. * Make frame / command dispatch async * Make a couple more methods async * Update Makefile * Do not release a SemaphoreSlim that is about to be disposed. * Fix toxiproxy duplicated entity for good, hopefully * Add two missing `.ConfigureAwait(false)` calls * Add missing `.ConfigureAwait(false)` call
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1472-20240221
branch
from
f81afd5
to
2b1467b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix to #1472
ISession.TransmitHeartbeatWriteTimerCallbackto beasyncand useWriteAsync