Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue simplifying code #1507

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Commits on Feb 28, 2024

  1. Continue simplifying code

    Part of #1472
    
    * Move some overrides to their base class
    
    * Simplify method, add comments
    
    * Try to figure out CI error here - https://github.com/rabbitmq/rabbitmq-dotnet-client/actions/runs/8072267202/job/22053764839
    
    * Ensure `_closeReason` is not null
    
    * Remove or address TODOs
    
    * Revert to calling `AbortAsync` in `Dispose` for connections and channels
    
    * Add test showing that `CloseAsync` is not required before `Dispose`
    lukebakken committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7c75648 View commit details
    Browse the repository at this point in the history