Only add x-dotnet-pub-seq-no when tracking enabled
#1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Should the CreateChannelOptions documentation for the property be updated to indicate the header gets added when publisher confirms tracking is enabled? |
lukebakken
force-pushed
the
lukebakken/only-add-pub-seq-no-if-tracking-enabled
branch
from
ed61296
to
66cac49
Compare
If a user only enables publisher confirms for a channel, but _NOT_ automatic tracking, it will be up to them to correlate a `basic.return` with a sequence number.
…ed` adds a header to every message.
lukebakken
force-pushed
the
lukebakken/only-add-pub-seq-no-if-tracking-enabled
branch
from
66cac49
to
e7f1b3f
Compare
danielmarbach
approved these changes
Oct 23, 2024
lukebakken
deleted the
lukebakken/only-add-pub-seq-no-if-tracking-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user only enables publisher confirms for a channel, but NOT automatic tracking, it will be up to them to correlate a
basic.returnwith a sequence number.