Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish nack metrics by requeue flag #1469

Conversation

ohksj77
Copy link
Contributor

@ohksj77 ohksj77 commented Nov 10, 2024

Proposed Changes

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@acogoluegnes
Copy link
Contributor

Thanks for this contribution. I edited some minor details but it created another PR. I will close this PR and you are welcome to follow up on #1476.

@ohksj77
Copy link
Contributor Author

ohksj77 commented Nov 12, 2024

Thanks for this contribution. I edited some minor details but it created another PR. I will close this PR and you are welcome to follow up on #1476.

Thank you for adding to my PR needs. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants