make CI: Run Dialyzer

rabbitmq · Sep 12, 2024 · b9b42bf · b9b42bf
1 parent 98a0f32
commit b9b42bf
Showing 1 changed file with 39 additions and 8 deletions.
diff --git a/.github/workflows/test-make-jobs.yaml b/.github/workflows/test-make-jobs.yaml
@@ -13,7 +13,7 @@ on:
         type: string
 jobs:
   test-rabbit:
-    name: Test rabbit
+    name: Test and type check rabbit
     strategy:
       fail-fast: false
       matrix:
@@ -28,6 +28,7 @@ jobs:
           - ct-metadata_store_clustering
           - ct-quorum_queue
           - ct-rabbit_stream_queue
+          - dialyze
     uses: ./.github/workflows/test-make-target.yaml
     with:
       erlang_version: ${{ inputs.erlang_version }}
@@ -37,17 +38,23 @@ jobs:
       plugin: rabbit
 
   test-rabbitmq-mqtt:
-    name: Test rabbitmq_mqtt
+    name: Test and type check rabbitmq_mqtt
+    strategy:
+      fail-fast: false
+      matrix:
+        make_target:
+          - parallel-ct-set-1
+          - dialyze
     uses: ./.github/workflows/test-make-target.yaml
     with:
       erlang_version: ${{ inputs.erlang_version }}
       elixir_version: ${{ inputs.elixir_version }}
       metadata_store: ${{ inputs.metadata_store }}
-      make_target: parallel-ct-set-1
+      make_target: ${{ matrix.make_target }}
       plugin: rabbitmq_mqtt
 
-  test-plugin-generic:
-    name: Test plugins
+  test-plugin:
+    name: Test and type check plugins
     strategy:
       fail-fast: false
       matrix:
@@ -91,12 +98,38 @@ jobs:
           - rabbitmq_web_dispatch
           - rabbitmq_web_mqtt
           - rabbitmq_web_stomp
+          # These do not have tests at this time. Only Dialyzer.
+          - rabbitmq_ct_client_helpers
+          - rabbitmq_random_exchange
+          - rabbitmq_top
+          - rabbitmq_web_mqtt_examples
+          - rabbitmq_web_stomp_examples
+          - trust_store_http
+    uses: ./.github/workflows/test-make-target.yaml
+    with:
+      erlang_version: ${{ inputs.erlang_version }}
+      elixir_version: ${{ inputs.elixir_version }}
+      metadata_store: ${{ inputs.metadata_store }}
+      make_target: check
+      plugin: ${{ matrix.plugin }}
+
+# We don't want to run some plugins' tests here.
+# But we still want to run Dialyzer.
+  type-check-plugin:
+    name: Type check plugins
+    strategy:
+      fail-fast: false
+      matrix:
+        plugin:
+          - rabbitmq_aws
+          - rabbitmq_ct_helpers
+          - rabbitmq_peer_discovery_aws
     uses: ./.github/workflows/test-make-target.yaml
     with:
       erlang_version: ${{ inputs.erlang_version }}
       elixir_version: ${{ inputs.elixir_version }}
       metadata_store: ${{ inputs.metadata_store }}
-      make_target: tests
+      make_target: dialyze
       plugin: ${{ matrix.plugin }}
 
 # @todo Test rabbitmq_cli
@@ -106,5 +139,3 @@ jobs:
 #      run: |
 #        bazel build //deps/rabbitmq_cli:compile_warnings_as_errors \
 #          --verbose_failures
-
-# @todo Dialyzer