Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: Convert '_' to '-' in $AWS_ECS_CLUSTER_NAME (backport #10023) (backport #10024) #10025

Merged
merged 1 commit into from
Dec 1, 2023
Merged

GitHub Actions: Convert '_' to '-' in $AWS_ECS_CLUSTER_NAME (backport #10023) (backport #10024) #10025

merged 1 commit into from
Dec 1, 2023

Commits on Dec 1, 2023

  1. GitHub Actions: Convert '_' to '-' in $AWS_ECS_CLUSTER_NAME 

    [Why]
The AWS ECS cluster name must match the regex `[a-zA-Z][-a-zA-Z0-9]*`.
Underscores are forbidden.

[How]
Like '.' was converted, we convert '_' to '.' using Bash parameter
expansion.

(cherry picked from commit b3dac51)
(cherry picked from commit 612496f)
    @dumbbell @mergify
    dumbbell authored and mergify[bot] committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    4308dc8 View commit details
    Browse the repository at this point in the history