rabbit_peer_discovery: Add pre/post discovery steps #10763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] The Consul peer discovery backend needs to create a session before it can acquire a lock. This session is also required for nodes to discover each other. This session was created as part of the lock callback. However, after pull request #9797, the lock was only acquired if and when a node had to join another one. Thus, after the actual discovery phase. This broke Consul peer discovery because the discovery was performed before that Consul session was created. [How] We introduce two new callbacks, `pre_discovery/0` and `post_discovery/1` to allow a backend to perform actions before and after the whole discover/lock/join process. To remain compatible with other peer discovery backend, the new callbacks are optional.
…callbacks [Why] The Consul peer discovery backend needs to create a session before it can acquire a lock. This session is also required for nodes to discover each other. It must open the session before the `list_nodes/0` callback can return meaningful results. [How] The new `pre_discovery/0` and `post_discovery/1` callbacks are used to create and delete that session before the whole discover/lock/join process. Fixes #10760.
dumbbell
force-pushed
the
peer-disc-add-setup-teardown-around-discovery
branch
from
496cfde
to
33dc0f2
Compare
12 tasks
|
This approch was superseded by #11045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The Consul peer discovery backend needs to create a session before it can acquire a lock. This session is also required for nodes to discover each other.
This session was created as part of the lock callback. However, after pull request #9797, the lock was only acquired if and when a node had ot join another one. Thus, after the actual discovery phase. This broke Consul peer discovery because the discovery was performed before that Consul session was created.
How
We introduce two new callbacks,
pre_discovery/0andpost_discovery/1to allow a backend to perform actions before and after the whole discover/lock/join process. The new callbacks are used by the Consul peer discovery backend to create and delete that session.To remain compatible with other peer discovery backend, the new callbacks are optional.
Fixes #10760.