Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaring an exchange with an invalid type is a precondition failure (backport #11214) (backport #11215) #11216

Merged
merged 1 commit into from
May 12, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 12, 2024

Proposed Changes

Declaring an exchange with an invalid type should be a precondition failure, not a invalid command that closes the whole connection, interrupting all other channels.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

When doing channel pooling and a single client/channel declares a bad exchange type all other channels/clients will be disconnected which doesn't makes sense imho.


This is an automatic backport of pull request #11214 done by Mergify.
This is an automatic backport of pull request #11215 done by Mergify.

Not a invalid command that closes the whole connection.

(cherry picked from commit b6aacb7)
(cherry picked from commit 312b3e0)
@michaelklishin michaelklishin added this to the 3.12.15 milestone May 12, 2024
@michaelklishin michaelklishin merged commit b265f62 into v3.12.x May 12, 2024
6 of 11 checks passed
@michaelklishin michaelklishin deleted the mergify/bp/v3.12.x/pr-11215 branch May 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants