Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BCC from x-death routing-keys (backport #11230) #11232

Merged
merged 1 commit into from
May 14, 2024

Commits on May 14, 2024

  1. Remove BCC from x-death routing-keys

    This commit is a follow up of #11174
    which broke the following Java client test:
    ```
    ./mvnw verify -P '!setup-test-cluster' -Drabbitmqctl.bin=DOCKER:rabbitmq -Dit.test=DeadLetterExchange#deadLetterNewRK
    ```
    
    The desired documented behaviour is the following:
    > routing-keys: the routing keys (including CC keys but excluding BCC ones) the message was published with
    
    This behaviour should be respected also for messages dead lettered into a
    stream. Therefore, instead of first including the BCC keys in the `#death.routing_keys` field
    and removing it again in mc_amqpl before sending the routing-keys to the
    client as done in v3.13.2 in
    https://github.com/rabbitmq/rabbitmq-server/blob/dc25ef53292eb0b34588ab8eaae61082b966b784/deps/rabbit/src/mc_amqpl.erl#L527
    we instead omit directly the BCC keys from `#death.routing_keys` when
    recording a death event.
    
    This commit records the BCC keys in their own mc `bcc` annotation in `mc_amqpl:init/1`.
    
    (cherry picked from commit 90a4010)
    ansd authored and mergify[bot] committed May 14, 2024
    Configuration menu
    Copy the full SHA
    f8ddfe6 View commit details
    Browse the repository at this point in the history