Increase the timeout when batch deleting permissions #12276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a vhost with many user/topic permissions (10k-100k users with one permission each) is very slow in the current implementation of Khepri.
khepri_tree:eval_keep_while_conditions
is particularly slow, mainly on OS X but it is also a bit slower in Linux (tested in Ubuntu) than the equivalent Mnesia operation to delete the permissions.This PR allows the
rabbitmqctl delete_vhost <vhost>
command to finish without a timeout, even if still equally slow.