Tweak wording around experimental feature flags (Khepri) #12286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates Khepri FF description to be more correct and to the point. It also tweaks the management UI copywriting so that it does not recommend against the use of Khepri in production as it is much more mature in 4.0.
dcorbacho
approved these changes
Sep 12, 2024
MirahImage
approved these changes
Sep 12, 2024
the-mikedavis
approved these changes
Sep 12, 2024
HowardTwine
reviewed
Sep 12, 2024
There was a problem hiding this comment.
Could we change the wording to
"Feature flags listed below are optional, these are new features to this release and will not be automatically enabled. Once enabled Khepri cannot be disabled. "
Any more wording that this gives the user a reason not to use Khepri. Sometimes less is more ;-)
The term 'experimental' in itself is enough of a reason for users to stay away.
There was a problem hiding this comment.
@HowardTwine most of the team have "mob-programmed" to arrive at the following wording changes #12294. There will be some doc guide changes of a similar kind.
michaelklishin
added a commit
that referenced
this pull request
Sep 12, 2024
Tweak wording around experimental feature flags (Khepri) (backport #12286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Khepri FF description to be more correct and to the point.
It also tweaks the management UI copywriting so
that it does not recommend against the use of
Khepri in production as it is much more mature
in 4.0.