Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Log errors from ranch:handshake" (backport #12304) #12305

Merged
merged 1 commit into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. Revert "Log errors from ranch:handshake" (#12304)

    This reverts commit 620fff2.
    
    It intoduced a regression in another area - a TCP health check,
    such as the default (with cluster-operator) readinessProbe,
    on a TLS-enabled instance would log a `rabbit_reader` crash
    every few seconds:
    ```
    tls-server-0 rabbitmq 2024-09-13 09:03:13.010115+00:00 [error] <0.999.0>   crasher:
    tls-server-0 rabbitmq 2024-09-13 09:03:13.010115+00:00 [error] <0.999.0>     initial call: rabbit_reader:init/3
    tls-server-0 rabbitmq 2024-09-13 09:03:13.010115+00:00 [error] <0.999.0>     pid: <0.999.0>
    tls-server-0 rabbitmq 2024-09-13 09:03:13.010115+00:00 [error] <0.999.0>     registered_name: []
    tls-server-0 rabbitmq 2024-09-13 09:03:13.010115+00:00 [error] <0.999.0>     exception error: no match of right hand side value {error, handshake_failed}
    tls-server-0 rabbitmq 2024-09-13 09:03:13.010115+00:00 [error] <0.999.0>       in function  rabbit_reader:init/3 (rabbit_reader.erl, line 171)
    ```
    
    (cherry picked from commit f0f7500)
    mkuratczyk authored and mergify[bot] committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bafbdc4 View commit details
    Browse the repository at this point in the history