Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2: support scope aliases in rabbitmq.conf #12439

Merged
merged 9 commits into from
Oct 9, 2024

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Oct 3, 2024

Proposed Changes

Implements feature request #12210

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

This PR is accompanied by docs PR rabbitmq/rabbitmq-website#2091

@MarcialRosales MarcialRosales self-assigned this Oct 3, 2024
@MarcialRosales MarcialRosales force-pushed the support-scope-aliases-in-cuttlefish-style branch from 90e6017 to ca716d4 Compare October 4, 2024 13:03
@MarcialRosales MarcialRosales marked this pull request as ready for review October 4, 2024 14:58
@michaelklishin michaelklishin force-pushed the support-scope-aliases-in-cuttlefish-style branch from ca716d4 to 96571e0 Compare October 6, 2024 22:35
@michaelklishin michaelklishin changed the title Support scope aliases in cuttlefish style OAuth 2: support scope aliases in rabbitmq.conf Oct 6, 2024
@mergify mergify bot added the bazel label Oct 7, 2024
@MarcialRosales MarcialRosales force-pushed the support-scope-aliases-in-cuttlefish-style branch from abf8fae to 62fc6a3 Compare October 8, 2024 18:44
Copy link
Member

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce the failures locally on both Erlang 26.2 and 27.1:

rabbit_oauth2_schema_SUITE > test_with_one_oauth_provider
    #1. {error,
            {{badmatch,#{<<"keycloak">> => [{issuer,"https://rabbit"}]}},
             [{rabbit_oauth2_schema_SUITE,test_with_one_oauth_provider,1,
                  [{file,"rabbit_oauth2_schema_SUITE.erl"},{line,106}]},
              {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
              {test_server,run_test_case_eval1,6,
                  [{file,"test_server.erl"},{line,1302}]},
              {test_server,run_test_case_eval,9,
                  [{file,"test_server.erl"},{line,1234}]}]}}

rabbit_oauth2_schema_SUITE > test_with_many_oauth_providers
    #1. {error,
            {{badmatch,
                 #{<<"keycloak">> => [{issuer,"https://keycloak"}],
                   <<"uaa">> =>
                       [{issuer,"https://uaa"},
                        {discovery_endpoint_path,"/some-path"}]}},
             [{rabbit_oauth2_schema_SUITE,test_with_many_oauth_providers,1,
                  [{file,"rabbit_oauth2_schema_SUITE.erl"},{line,125}]},
              {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
              {test_server,run_test_case_eval1,6,
                  [{file,"test_server.erl"},{line,1302}]},
              {test_server,run_test_case_eval,9,
                  [{file,"test_server.erl"},{line,1234}]}]}}

rabbit_oauth2_schema_SUITE > test_oauth_providers_signing_keys
    #1. {error,
            {{badmatch,
                 #{<<"keycloak">> =>
                       [{issuer,"https://keycloak"},
                        {signing_keys,
                            #{<<"1">> => {pem,<<"I'm not a certificate">>},
                              <<"2">> =>
                                  {pem,<<"I'm not a certificate">>}}}]}},
             [{rabbit_oauth2_schema_SUITE,test_oauth_providers_signing_keys,
                  1,
                  [{file,"rabbit_oauth2_schema_SUITE.erl"},{line,277}]},
              {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
              {test_server,run_test_case_eval1,6,
                  [{file,"test_server.erl"},{line,1302}]},
              {test_server,run_test_case_eval,9,
                  [{file,"test_server.erl"},{line,1234}]}]}}
                  ```

@michaelklishin michaelklishin force-pushed the support-scope-aliases-in-cuttlefish-style branch from be3b454 to 423b591 Compare October 9, 2024 14:57
@michaelklishin
Copy link
Member

michaelklishin commented Oct 9, 2024

The forced push was a rebase on top of main to get #12500.

@michaelklishin michaelklishin merged commit 6c50ce2 into main Oct 9, 2024
291 checks passed
@michaelklishin michaelklishin deleted the support-scope-aliases-in-cuttlefish-style branch October 9, 2024 15:45
@michaelklishin michaelklishin added this to the 4.1.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants