-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth 2: support scope aliases in rabbitmq.conf #12439
Merged
michaelklishin
merged 9 commits into
main
from
support-scope-aliases-in-cuttlefish-style
Oct 9, 2024
Merged
OAuth 2: support scope aliases in rabbitmq.conf #12439
michaelklishin
merged 9 commits into
main
from
support-scope-aliases-in-cuttlefish-style
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcialRosales
force-pushed
the
support-scope-aliases-in-cuttlefish-style
branch
from
October 4, 2024 13:03
90e6017
to
ca716d4
Compare
michaelklishin
force-pushed
the
support-scope-aliases-in-cuttlefish-style
branch
from
October 6, 2024 22:35
ca716d4
to
96571e0
Compare
michaelklishin
changed the title
Support scope aliases in cuttlefish style
OAuth 2: support scope aliases in rabbitmq.conf
Oct 6, 2024
MarcialRosales
force-pushed
the
support-scope-aliases-in-cuttlefish-style
branch
from
October 8, 2024 18:44
abf8fae
to
62fc6a3
Compare
michaelklishin
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can reproduce the failures locally on both Erlang 26.2 and 27.1:
rabbit_oauth2_schema_SUITE > test_with_one_oauth_provider
#1. {error,
{{badmatch,#{<<"keycloak">> => [{issuer,"https://rabbit"}]}},
[{rabbit_oauth2_schema_SUITE,test_with_one_oauth_provider,1,
[{file,"rabbit_oauth2_schema_SUITE.erl"},{line,106}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}
rabbit_oauth2_schema_SUITE > test_with_many_oauth_providers
#1. {error,
{{badmatch,
#{<<"keycloak">> => [{issuer,"https://keycloak"}],
<<"uaa">> =>
[{issuer,"https://uaa"},
{discovery_endpoint_path,"/some-path"}]}},
[{rabbit_oauth2_schema_SUITE,test_with_many_oauth_providers,1,
[{file,"rabbit_oauth2_schema_SUITE.erl"},{line,125}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}
rabbit_oauth2_schema_SUITE > test_oauth_providers_signing_keys
#1. {error,
{{badmatch,
#{<<"keycloak">> =>
[{issuer,"https://keycloak"},
{signing_keys,
#{<<"1">> => {pem,<<"I'm not a certificate">>},
<<"2">> =>
{pem,<<"I'm not a certificate">>}}}]}},
[{rabbit_oauth2_schema_SUITE,test_oauth_providers_signing_keys,
1,
[{file,"rabbit_oauth2_schema_SUITE.erl"},{line,277}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1302}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1234}]}]}}
```
WIP Add translation function
scope_aliases
scope_aliases using cuttlefish
michaelklishin
force-pushed
the
support-scope-aliases-in-cuttlefish-style
branch
from
October 9, 2024 14:57
be3b454
to
423b591
Compare
The forced push was a rebase on top of |
michaelklishin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Implements feature request #12210
Types of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyThis PR is accompanied by docs PR rabbitmq/rabbitmq-website#2091