Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors and loading #50

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Errors and loading #50

merged 3 commits into from
Jan 3, 2024

Conversation

rachelsoae
Copy link
Owner

What I did:

  • Add styling and route for Error path (nonsense URL)
  • Pull Menu into its own component
  • Delete unused Sass partial files

Did this break anything?

  • No
  • Yes

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Refactor(DRY-ing up/ reorganizing code, etc.)
  • Super small fix (Corrected a typo, removed a comment, etc.)
  • Skip all the other stuff and briefly explain the fix.

Checklist:

  • If this code needs to be tested, all tests are passing
  • The code runs locally
  • There are comments where clarification/ organization is needed
  • The code is DRY. If it's not, I tried my best
  • I reviewed my code before pushing

What's next?
Clean up README for MVP
Start iterating on Cypress testing

@rachelsoae rachelsoae added the feature New feature or request label Jan 3, 2024
Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
portfolio ✅ Ready (Inspect) Visit Preview Jan 3, 2024 8:43pm

@rachelsoae rachelsoae merged commit c1d6fb4 into main Jan 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant