Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to pull new tags if fetching a tag fails #37

Merged
merged 1 commit into from
May 7, 2024

Conversation

eliminmax
Copy link
Contributor

@eliminmax eliminmax commented May 5, 2024

Checklist

Description

I edited the git_fetch function in tools.py, so that if repo.git.checkout(version) fails with a git.GitCommandError, it tries to fetch tags from origin and tries one more time, instead of immediately failing.

I am not super familiar with the GitPython module, but I did not see anything in the docs that would point to cleaner way to do things than pass the --tags flag.

@eliminmax
Copy link
Contributor Author

eliminmax commented May 6, 2024

Working on investigating the failed checks. Unchecked the "ready to merge" check in the meantime.

I'm currently in the middle of installing older python versions with pyenv to be able to run the tests locally.

@trufae
Copy link
Contributor

trufae commented May 7, 2024

Thanks for taking care of this

@trufae
Copy link
Contributor

trufae commented May 7, 2024

the "1 C901 'PackageManager.install_package' is too complex (11)" seems like a bad excuse to fail anyway

@trufae trufae merged commit 5578bee into radareorg:master May 7, 2024
3 of 5 checks passed
@trufae
Copy link
Contributor

trufae commented May 7, 2024

Merging because the failing tests are also broken on master, so unrelated to your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants